Skip to content

Update default.conf.sample to deny dotfile access#41

Open
nemchik wants to merge 2 commits into
mainfrom
deny-dotfile-access
Open

Update default.conf.sample to deny dotfile access#41
nemchik wants to merge 2 commits into
mainfrom
deny-dotfile-access

Conversation

@nemchik
Copy link
Copy Markdown
Member

@nemchik nemchik commented Feb 8, 2026

No description provided.

Signed-off-by: Eric Nemchik <eric@nemchik.com>
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-c67613bb-dev-a1d0efedca5baca7db824df12cd6e8fe6be9bde4-pr-41/index.html
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-c67613bb-dev-a1d0efedca5baca7db824df12cd6e8fe6be9bde4-pr-41/shellcheck-result.xml

Tag Passed
amd64-3.8.1-pkg-c67613bb-dev-a1d0efedca5baca7db824df12cd6e8fe6be9bde4-pr-41
arm64v8-3.8.1-pkg-c67613bb-dev-a1d0efedca5baca7db824df12cd6e8fe6be9bde4-pr-41

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-c67613bb-dev-7b0e4b519c306ecd904f534a801f53e7328c285b-pr-41/index.html
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-c67613bb-dev-7b0e4b519c306ecd904f534a801f53e7328c285b-pr-41/shellcheck-result.xml

Tag Passed
amd64-3.8.1-pkg-c67613bb-dev-7b0e4b519c306ecd904f534a801f53e7328c285b-pr-41
arm64v8-3.8.1-pkg-c67613bb-dev-7b0e4b519c306ecd904f534a801f53e7328c285b-pr-41

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-962c0199-dev-654ce886027116dc5e2b4a2303930010b1db478d-pr-41/index.html
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-962c0199-dev-654ce886027116dc5e2b4a2303930010b1db478d-pr-41/shellcheck-result.xml

Tag Passed
amd64-3.8.1-pkg-962c0199-dev-654ce886027116dc5e2b4a2303930010b1db478d-pr-41
arm64v8-3.8.1-pkg-962c0199-dev-654ce886027116dc5e2b4a2303930010b1db478d-pr-41

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-9c03ee8b-dev-de97b7957300b9d7e165a479b4ceb05056890b99-pr-41/index.html
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-9c03ee8b-dev-de97b7957300b9d7e165a479b4ceb05056890b99-pr-41/shellcheck-result.xml

Tag Passed
amd64-3.8.1-pkg-9c03ee8b-dev-de97b7957300b9d7e165a479b4ceb05056890b99-pr-41
arm64v8-3.8.1-pkg-9c03ee8b-dev-de97b7957300b9d7e165a479b4ceb05056890b99-pr-41

Signed-off-by: Eric Nemchik <eric@nemchik.com>
Copilot AI review requested due to automatic review settings May 5, 2026 21:45
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the default nginx site configuration sample to better protect sensitive “dotfiles” from direct HTTP access, while explicitly allowing access to /.well-known paths (commonly used for ACME challenges and similar well-known resources).

Changes:

  • Added an explicit allow rule for /.well-known.
  • Added a deny rule returning 404 for all other dotfile paths (replacing the narrower .ht* deny).
  • Updated the documentation changelog and refreshed the config version header.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
root/defaults/nginx/site-confs/default.conf.sample Adds /.well-known allow and a broader dotfile deny rule; minor formatting/version updates.
readme-vars.yml Documents the migration note advising existing users to update their nginx site conf.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# deny access to all dotfiles
location ~ /\. {
access_log off;
log_not_found off;
index index.html index.htm index.php;

# Allow access to the ".well-known" directory
location ^~ /.well-known {
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-3c9260f7-dev-a6847eb21601a5421a3fdb2f7fb963b7c80b05fb-pr-41/index.html
https://ci-tests.linuxserver.io/lspipepr/xbackbone/3.8.1-pkg-3c9260f7-dev-a6847eb21601a5421a3fdb2f7fb963b7c80b05fb-pr-41/shellcheck-result.xml

Tag Passed
amd64-3.8.1-pkg-3c9260f7-dev-a6847eb21601a5421a3fdb2f7fb963b7c80b05fb-pr-41
arm64v8-3.8.1-pkg-3c9260f7-dev-a6847eb21601a5421a3fdb2f7fb963b7c80b05fb-pr-41

@LinuxServer-CI LinuxServer-CI moved this from PRs Ready For Team Review to PRs in Issue & PR Tracker May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants