Pass the first-interaction wrapper its own input names - #406
Open
tigerblue77 wants to merge 1 commit into
Open
tigerblue77 wants to merge 1 commit into
tigerblue77 wants to merge 1 commit into
Conversation
The linuxserver first-interaction composite action takes issue_message, pr_message and repo_token, but the greetings template still passes the issue-message, pr-message and repo-token names of actions/first-interaction@v1. GitHub drops them, the wrapper hands empty messages to actions/first-interaction@v3.1.0, and that fails on every opened issue and pull request with "Input required and not supplied: issue_message". closes linuxserver#405 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RmwHZxdRuWgp9chBZTZTMn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
greetings.yml.j2now passesissue_message,pr_messageandrepo_token, the input names declared bylinuxserver/github-workflows/.github/actions/first-interaction@v1, instead of theissue-message,pr-messageandrepo-tokennames ofactions/first-interaction@v1.Benefits of this PR and context:
closes #405
The
greetingjob stops failing on every opened issue and pull request of the repositories generated from this template, and first-time contributors get their message again.How Has This Been Tested?
project_deprecation_statusfalse and true: valid YAML whosewithkeys match the wrapper's inputs, and actionlint 1.7.12 reports nothing.actions/first-interactionv3.1.0dist/index.jslocally on anopenedissue event. With empty messages, which is what the wrapper passes today, it fails withInput required and not supplied: issue_message. With the messages set, it gets past the inputs to the GitHub API calls.Source / References: