sn-item: Fix error handling to address SIGSEGV

[leigh123linux]

Fix error handling to address SIGSEGV

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2477415
https://bugzilla.redhat.com/show_bug.cgi?id=2428140

[Copilot]

Pull request overview

This PR addresses a SIGSEGV in the status notifier item watcher by ensuring in-flight async D-Bus calls are cancelled during object disposal, preventing callbacks from touching cleared proxy state.

Changes:

• Cancel GCancellable in sn_item_dispose() before clearing proxies to abort in-flight/queued async operations safely.
• Add a NULL-guard in get_all_properties_callback() to bail out if proxies were cleared before processing results.

Comments suppressed due to low confidence (1)

xapp-sn-watcher/sn-item.c:181

• Now that dispose() actively cancels item->cancellable, any pending async ops (e.g. the g_dbus_proxy_new() in initialize_item()) will complete with G_IO_ERROR_CANCELLED. In property_proxy_acquired(), the CANCELLED branch currently does not g_error_free(error) and does not return, so it will continue initializing the item with prop_proxy == NULL. Please make the CANCELLED path free the error and return early to avoid leaks and inconsistent state.

    g_cancellable_cancel (item->cancellable);

    g_clear_pointer (&item->sortable_name, g_free);
    g_clear_object (&item->status_icon);
    g_clear_object (&item->prop_proxy);
    g_clear_object (&item->sn_item_proxy);
    g_clear_object (&item->cancellable);

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

xapp-sn-watcher/sn-item.c:1178

• With the new dispose-time g_cancellable_cancel(), g_dbus_proxy_new_finish() can now fail with G_IO_ERROR_CANCELLED. In that case this callback currently neither frees error nor returns, and it proceeds with item->prop_proxy == NULL to connect signals/create the status icon/queue updates, which can lead to crashes or inconsistent state. Handle the cancelled case explicitly by freeing error and returning early (and ensure the SnItem ref is released in the same cleanup path).

    item->prop_proxy = g_dbus_proxy_new_finish (res, &error);

    if (error != NULL)
    {
        if (!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED))
        {
            g_critical ("Could not get property proxy for %s: %s\n",
                        g_dbus_proxy_get_name (item->sn_item_proxy),
                        error->message);
            g_error_free (error);
            return;
        }
    }

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.