Skip to content

feat(net-view): add disconnect button for connected items#574

Open
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0715-story-41277
Open

feat(net-view): add disconnect button for connected items#574
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0715-story-41277

Conversation

@MyLeeJiEun

Copy link
Copy Markdown
Contributor
  1. Added NetCommonButton, a custom QAbstractButton with rounded background and hover/press states
  2. Replaced hover icon on connect button with a dedicated disconnect button for wireless and wired items
  3. Implemented hover behavior: shows disconnect button and hides connect button when hovered
  4. Added overrides for setHover in NetWirelessWidget and NetWiredWidget
  5. Updated translations across all supported languages for the "Disconnect" string

Log: Add a hover-revealed disconnect button for connected network items
Influence: Changes hover UX for connected network items

feat(net-view): 添加已连接网络项的断开按钮

  1. 新增 NetCommonButton 自定义按钮控件,支持圆角背景和悬停/按压状态
  2. 将无线和有线已连接项的断开功能从悬停图标改为独立断开按钮
  3. 实现悬停交互:悬停时显示断开按钮,隐藏连接按钮
  4. 在 NetWirelessWidget 和 NetWiredWidget 中重写 setHover 方法
  5. 更新所有支持语言的翻译,添加"断开连接"文本

Log: 为已连接的网络项添加悬停显示的断开按钮
PMS: STORY-41277
Influence: 改变已连接网络项的悬停交互方式

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @MyLeeJiEun, your pull request is larger than the review limit of 150000 diff characters

@deepin-ci-robot

Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread net-view/window/private/netcommonbutton.h Outdated
mhduiy
mhduiy previously approved these changes Jul 15, 2026
@MyLeeJiEun
MyLeeJiEun force-pushed the fork-from-master-0715-story-41277 branch from 44fadd1 to 2f8fad4 Compare July 16, 2026 03:43
1. Added NetCommonButton, a custom QAbstractButton with rounded background and hover/press states
2. Replaced hover icon on connect button with a dedicated disconnect button for wireless and wired items
3. Implemented hover behavior: shows disconnect button and hides connect button when hovered
4. Added overrides for setHover in NetWirelessWidget and NetWiredWidget
5. Updated translations across all supported languages for the "Disconnect" string

Log: Add a hover-revealed disconnect button for connected network items
Influence: Changes hover UX for connected network items

feat(net-view): 添加已连接网络项的断开按钮

1. 新增 NetCommonButton 自定义按钮控件,支持圆角背景和悬停/按压状态
2. 将无线和有线已连接项的断开功能从悬停图标改为独立断开按钮
3. 实现悬停交互:悬停时显示断开按钮,隐藏连接按钮
4. 在 NetWirelessWidget 和 NetWiredWidget 中重写 setHover 方法
5. 更新所有支持语言的翻译,添加"断开连接"文本

Log: 为已连接的网络项添加悬停显示的断开按钮
PMS: STORY-41277
Influence: 改变已连接网络项的悬停交互方式
@MyLeeJiEun
MyLeeJiEun force-pushed the fork-from-master-0715-story-41277 branch from 2f8fad4 to ad2f984 Compare July 16, 2026 12:58
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants