Closed
Fix T480s-maximized.md: apply PR #218 content with review-identified corrections#220
Conversation
- Fix grammar: comma-splice 'however' → '; however,' on line 25 - Fix casing: 'CH341a' → 'CH341A' (correct hardware name) - Fix casing: 'HEADS' → 'Heads' (consistent project name) - Fix typo: '[progarmmer]' → '[programmer]' (two occurrences) - Fix hostname: '[user@h4ckb0x ~]$' → '[user@flashing ~]$' (generic placeholder) - Fix write command: replace hard-coded chip/filename with YYY/t480s-maximized.rom - Fix diff command: 't480_original_tb' → 't480s_original_tb' - Fix tb.bin mismatch: align description with write command (t480s_tb.bin)
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix T480s-maximized.md: apply PR #218 content with review-identified corrections
Jul 14, 2026
tlaurion
marked this pull request as ready for review
July 14, 2026 20:21
There was a problem hiding this comment.
Pull request overview
Updates the T480s maximized flashing guide to standardize on flashrom (instead of mixing flashprog/flashrom) and to incorporate review-driven corrections so the instructions are more consistent and copy/paste-friendly.
Changes:
- Rewrites the BIOS and Thunderbolt flashing command examples to use
flashromand updates the sample output blocks accordingly. - Fixes several documentation issues identified in the prior review (naming, grammar, placeholders, and filename consistency).
- Clarifies/adjusts verification steps for BIOS and Thunderbolt dumps.
Comments suppressed due to low confidence (1)
Installing-and-Configuring/Flashing-Guides/T480s-maximized.md:128
- These checksum commands omit the
~/prefix even though the preceding flashrom reads explicitly write the dumps into~. If the reader isn’t currently in their home directory, copy/paste will fail with “No such file”.
sha256sum t480s_original_bios.bin
sha256sum t480s_original_bios_1.bin
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ``` | ||
|
|
||
| Flash the padded Thunderbolt firmware. The firmware file tb.bin is located in the blobs folder after you build the Heads locally, or in the CircleCI artifacts. | ||
| Flash the padded Thunderbolt firmware. The firmware file t480s_tb.bin is located in the blobs folder after you build the Heads locally, or in the CircleCI artifacts. |
| If the files differ or the chip content does not match the dump, try reconnecting your programmer to the SPI flash chip and make sure your flashrom software is up-to-date. | ||
|
|
||
|
|
||
| If they are the same, then write `t480s-maximized.rom` to the SPI flash chip: |
|
|
||
| ```shell | ||
| sudo flashprog -p serprog:dev=/dev/ttyACM0:spispeed=16M -c YYY -w ~/heads/build/x86/t480s-hotp-maximized/heads-t480s-hotp-maximized.rom | ||
| sudo flashrom --programmer [programmer] --chip YYY --write t480s-maximized.rom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates the PR #218 rewrite (flashprog → flashrom commands) and addresses all issues flagged in the associated review thread.
Fixes applied
; however,+ reworded clauseCH341a→CH341AHEADS→Heads(two occurrences, consistent with rest of docs)[progarmmer]→[programmer](two occurrences in shell commands — would break copy/paste)[user@h4ckb0x ~]$→[user@flashing ~]$(generic placeholder)W25Q128.V) and timestamped ROM filename replaced withYYYandt480s-maximized.romto match surrounding instructions and stay version-agnostict480_original_tb*.bin→t480s_original_tb*.bin(matches actual dump filenames created earlier in the guide)tb.bin→t480s_tb.binto match the--write ~/t480s_tb.bincommand immediately below