Repository navigation
Conversation
mawilk90
requested review from
ezilber-akamai and
psnoch-akamai
and removed request for
a team
October 5, 2026 11:55
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Devcloud URLs in all refreshed fixtures prevent default playback requests from matching.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Updates VPC and subnet invalid-label integration tests after ARB-8019.
Changes:
- Updates expected validation messages.
- Re-records affected fixtures.
| File | Description |
|---|---|
test/integration/vpc_test.go |
Updates VPC error assertions. |
test/integration/vpc_subnet_test.go |
Updates subnet error assertions. |
test/integration/fixtures/TestVPC_Create_Invalid.yaml |
Refreshes create fixture. |
test/integration/fixtures/TestVPC_Update_Invalid.yaml |
Refreshes update fixture. |
test/integration/fixtures/TestVPC_Subnet_Create_Invalid_data.yaml |
Refreshes subnet-create fixture. |
test/integration/fixtures/TestVPC_Subnet_Update_Invalid_Label.yaml |
Refreshes subnet-update fixture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mawilk90
force-pushed
the
hotfix/ARB-8019-incorrect-err-msg-refactor
branch
from
October 5, 2026 11:58
ee83e5d to
48f89de
Compare
psnoch-akamai
approved these changes
Oct 5, 2026
psnoch-akamai
left a comment
psnoch-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, pass locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Retest and refactor VPC and subnet tests failing due to ARB-8019 defect
✔️ How to Test
make fixtures TEST_ARGS="-run _Invalid_data"ormake test-int TEST_ARGS="-run _Invalid_data"