Repository navigation
Conversation
mawilk90
requested review from
ezilber-akamai
and
a lite review from Copilot
September 28, 2026 09:02
mawilk90
requested review from
lgarber-akamai
and removed request for
a team
September 28, 2026 09:02
mawilk90
added
new-feature
mawilk90
requested review from
psnoch-akamai
and removed request for
a team
September 28, 2026 09:02
mawilk90
added
the
do-not-merge
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical and moderate correctness issues remain in interface decoding, NAT Gateway modeling, request options, and subnet update handling.
Review effort: Lite
Findings: 1
Open (8)
What changed in this PR
Adds VPC NAT Gateway API support, related VPC associations, and unit/integration coverage.
Changes:
- Adds NAT Gateway models, endpoints, settings, and region capability.
- Extends subnet, interface, and IP models with NAT Gateway data.
- Adds fixtures and lifecycle integration tests.
| File | Description |
|---|---|
vpc_subnet.go |
NAT Gateway subnet support |
test/unit/vpc_test.go |
VPC creation coverage |
test/unit/vpc_subnets_test.go |
Subnet NAT Gateway coverage |
test/unit/vpc_ips_test.go |
VPC IP NAT coverage |
test/unit/nat_gateways_test.go |
NAT Gateway endpoint tests |
test/unit/interface_test.go |
Interface NAT coverage |
test/unit/fixtures/vpc_subnets_list.json |
Subnet list fixture |
test/unit/fixtures/vpc_subnet_update.json |
Subnet update fixture |
test/unit/fixtures/vpc_subnet_get.json |
Subnet get fixture |
test/unit/fixtures/vpc_subnet_create.json |
Subnet create fixture |
test/unit/fixtures/vpc_specific_ips_list.json |
Specific IPs fixture |
test/unit/fixtures/vpc_ips_list.json |
VPC IPs fixture |
test/unit/fixtures/nat_gateways_update.json |
NAT Gateway update fixture |
test/unit/fixtures/nat_gateways_list.json |
NAT Gateway list fixture |
test/unit/fixtures/nat_gateways_list_interfaces.json |
NAT Gateway interfaces fixture |
test/unit/fixtures/nat_gateways_list_addresses.json |
NAT Gateway addresses fixture |
test/unit/fixtures/nat_gateways_list_address_interfaces.json |
Address interfaces fixture |
test/unit/fixtures/nat_gateways_get.json |
NAT Gateway get fixture |
test/unit/fixtures/nat_gateways_get_types.json |
NAT Gateway types fixture |
test/unit/fixtures/nat_gateways_get_settings.json |
NAT Gateway settings fixture |
test/unit/fixtures/nat_gateways_get_address.json |
NAT Gateway address fixture |
test/unit/fixtures/nat_gateways_create.json |
NAT Gateway create fixture |
test/unit/fixtures/nat_gateways_add_address.json |
Add-address fixture |
test/unit/fixtures/interface_list.json |
Interface list fixture |
test/integration/vpc_subnet_test.go |
Subnet association integration test |
test/integration/network_nat_gateway_test.go |
NAT Gateway integration scenarios |
test/integration/fixtures/TestVPC_Subnet_WithNATGateway.yaml |
Subnet NAT fixture |
test/integration/fixtures/TestNATGateway_Update.yaml |
Update integration fixture |
test/integration/fixtures/TestNATGateway_GetTypes.yaml |
Types integration fixture |
test/integration/fixtures/TestNATGateway_GetSettings.yaml |
Settings integration fixture |
test/integration/fixtures/TestNATGateway_Create_smoke.yaml |
Creation smoke fixture |
regions.go |
NAT Gateway region capability |
nat_gateways.go |
NAT Gateway models and methods |
interfaces.go |
Interface NAT Gateway data |
instance_ips.go |
VPC IP NAT Gateway data |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mawilk90
removed
the
do-not-merge
ezilber-akamai
approved these changes
Sep 29, 2026
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests are passing locally!
psnoch-akamai
approved these changes
Oct 5, 2026
psnoch-akamai
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Created integration tests for VPC NAT Gateway service.
Note:
✔️ How to Test
make test-int TEST_ARGS="-run NATGateway"ormake fixtures TEST_ARGS="-run NATGateway"