Skip to content

TPT-4625: Fix the test and add an option to cleanup the testing linode instance - #244

Merged
zliang-akamai merged 3 commits into
linode:mainfrom
zliang-akamai:zhiwei/test-fix
Aug 27, 2026
Merged

zliang-akamai merged 3 commits into
linode:mainfrom
zliang-akamai:zhiwei/test-fix

Conversation

@zliang-akamai

@zliang-akamai zliang-akamai commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

📝 Description

Fix the test and add an option to cleanup the testing linode instance.

✔️ How to Test

QUICKTEST_CLEANUP_INSTANCE=1 make int-test

@zliang-akamai
zliang-akamai requested review from a team as code owners August 26, 2026 22:16
@zliang-akamai
zliang-akamai requested review from a team, mawilk90, psnoch-akamai and yec-akamai and a balanced review from Copilot and removed request for a team August 26, 2026 22:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the integration-test workflow for current Ansible output handling, SSH access, and optional Linode cleanup.

Changes:

  • Uses Ansible’s YAML result-format setting.
  • Adds the SSH public key during provisioning.
  • Adds optional test-instance cleanup and documentation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
README.md Documents optional instance cleanup.
Makefile Updates Ansible callback configuration.
integration-test/test.yaml Adds SSH authorization and cleanup logic.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread integration-test/test.yaml
Comment thread integration-test/test.yaml
Comment thread README.md
@zliang-akamai zliang-akamai changed the title Fix the test and add an option to cleanup the testing linode instance TPT-4625: Fix the test and add an option to cleanup the testing linode instance Aug 26, 2026
@zliang-akamai
zliang-akamai requested a balanced review from Copilot August 26, 2026 22:46
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@ezilber-akamai ezilber-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes locally!

@lgarber-akamai lgarber-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zliang-akamai
zliang-akamai merged commit 0bdda90 into linode:main Aug 27, 2026
4 checks passed
@zliang-akamai
zliang-akamai deleted the zhiwei/test-fix branch August 27, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants