Expose funding_redeem_script on Channel - #277
Open
elnafateh wants to merge 1 commit into
Open
Conversation
|
👋 I see @valentinewallace was un-assigned. |
benthecarman
requested changes
Sep 9, 2026
tankyleo
reviewed
Sep 9, 2026
tankyleo
left a comment
tankyleo
left a comment
Contributor
There was a problem hiding this comment.
@benthecarman would be cool to keep the upcoming taproot channels in mind, those do not have a "redeemscript", and I think we were considering tweaking the original upstream PR a while back.
tankyleo
reviewed
Sep 9, 2026
tankyleo
left a comment
tankyleo
left a comment
Contributor
There was a problem hiding this comment.
Can we gravitate towards exposing the script pubkey instead of the redeem script ? This would be nicely generic across all channel types. Either in this PR or in future PRs your call.
elnafateh
force-pushed
the
expose-funding-redeem-script
branch
from
September 9, 2026 23:57
241a980 to
55e311d
Compare
Collaborator
|
Let's wait on lightningdevkit/ldk-node#1093 for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #272 (1/2).
Adds hex-encoded funding_redeem_script to Channel