Skip to content

Pin encoding_rs for MSRV builds - #1092

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
tnull:2026-09-fix-msrv-encoding-rs
Sep 9, 2026
Merged

Pin encoding_rs for MSRV builds#1092
tnull merged 1 commit into
lightningdevkit:mainfrom
tnull:2026-09-fix-msrv-encoding-rs

Conversation

@tnull

@tnull tnull commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Keep the Rust 1.85 CI job resolving encoding_rs 0.8.35 because newer releases require Rust 1.88.

Keep the Rust 1.85 CI job resolving encoding_rs 0.8.35 because
newer releases require Rust 1.88.

Co-Authored-By: HAL 9000
@ldk-reviews-bot

ldk-reviews-bot commented Sep 9, 2026

Copy link
Copy Markdown

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull
tnull requested a review from benthecarman September 9, 2026 21:46

@benthecarman benthecarman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial

@tnull
tnull merged commit c54d971 into lightningdevkit:main Sep 9, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants