Update README.md for accuracy and Sunlight v0.9.0 changes - #18
Open
Preston12321 wants to merge 1 commit into
Open
Update README.md for accuracy and Sunlight v0.9.0 changes#18Preston12321 wants to merge 1 commit into
Preston12321 wants to merge 1 commit into
Conversation
mcpherrinm
reviewed
Aug 19, 2026
| # sunlight-secretmanager | ||
|
|
||
| sunlight-secretmanager is a command-line tool to manage a | ||
| [Sunlight](https://sunlight.dev/) CT Log's private key material. |
Contributor
There was a problem hiding this comment.
I think this undersells it a bit: The different format private keys are fundamentally derived from this, and we should be clear that the "seed material", fundamentally, is the private key
Contributor
Author
There was a problem hiding this comment.
Could you suggest an alternative wording? I'm just trying to avoid suggesting the sunlight-secretmanager generates or manages the actual private key files, which implies a very specific thing (i.e. a PEM- or DER-encoded file in the standard format).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some housekeeping on the readme to make it more accurate: