Remove customers: tags replaced them - #11
Merged
Merged
Conversation
Overview.customers, CustomerOverview, HostView.customer and CustomerId go from the protocol; ServerConfig.customers, Customer and a host's customer from the configuration, with the per-customer grouping. A server.toml that still has [[customers]] or a host's customer does not load, and says to tag the hosts instead. The view's "server is older than this view" banner no longer needs customers: an overview with no hosts and no problems yet a status other than ok can only come from a server older than both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the customer grouping, which tags replaced (#6). Unlike the rest of the protocol's history this is a deliberate removal, agreed after the structural review.
Removed
Overview.customers,CustomerOverview,HostView.customer,CustomerId.[[customers]](ServerConfig.customers,Customer) and a host'scustomer, with their validation.views::overview, which also had an always-emptyendpoints.customer: Nonein the local status view.Behaviour
server.tomlthat still has[[customers]]or a hostcustomerfails to load:[[customers]] and a host's customer are no longer read: tag the hosts instead (tags = ["<customer>"]).The check reads only the top-level
customerskey andcustomerdirectly inside a host, so app, probe or mute keys are never matched. It runs after the normal parse has succeeded, so syntax errors keep their line-only, secret-free message.skym-viewstill parses the new overview (customerswasserde(default)).customers.Verification
server.tomlloads with the new binary, which reachedlistening.[[customers]]is rejected with the message above.Upgrade
Server, then
skym-view. Agents are unchanged. The production configuration needs no edit.