Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
NumberBoxsets the arrow cursor on the control through its defaultstyle. While the underlying
TextBoxhas mouse capture during a clickor text selection, the cursor is resolved from the control itself, so
the IBeam cursor is replaced by the default arrow until the mouse
button is released.
TextBoxsets the IBeam cursor on the control, so the margins aroundthe left/right icons and the clear button also show the IBeam cursor
even though they are not part of the editable area.
What is the new behavior?
Fixes: #1770
NumberBoxsetsCursortoIBeam/Arrowon the templated controlbased on
IsEnabled, so the IBeam cursor is preserved while clickingand selecting text.
clear/spin button panel of
NumberBox.TextBoxicon presenters and clear button are wrapped intransparent grids using the arrow cursor, so icon and button margins no
longer show the IBeam cursor.
shows the arrow cursor everywhere.
Other information
XAML-only change, no public API changes.