fix: keep the server frontend install out of a parent pnpm workspace - #2056
Merged
Merged
Conversation
pnpm walks upward from the frontend directory and joins a workspace whose root is outside this repo, so the CMake install can target that workspace's node_modules. Pass --ignore-workspace so the frontend package stays local.
Owner
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2053
What changed and why
The server frontend target already runs
pnpm -C <frontend>.-Cselects the package directory, but pnpm still walks parent directories forpnpm-workspace.yaml. When that file lives above the checkout (a home directory workspace is enough),pnpm installjoins that workspace. That is the path that reinstalls the parentnode_modulesinstead ofexamples/server/frontend/node_modules.sdcpp-webuiis a single package: it haspackage.jsonandpnpm-lock.yaml, and nopnpm-workspace.yaml.--ignore-workspacekeeps the install,run build, andrun build:headeron that package.Verification
pnpm 11.21.0, with a parent
pnpm-workspace.yamlthat listsfrontend:pnpm -C frontend installreportedScope: all 2 workspace projects.pnpm --ignore-workspace -C frontend installinstalled only the frontend package, andnode_moduleswas created underfrontend/, not next to the parent workspace file.