fix(cli): resolve undefined mz_uncompress symbol on Windows#1719
Open
stduhpf wants to merge 1 commit into
Open
fix(cli): resolve undefined mz_uncompress symbol on Windows#1719stduhpf wants to merge 1 commit into
stduhpf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a build failure on Windows (lld-link: error: undefined symbol: mz_uncompress) caused by #1632.
Related Issue / Discussion
#1632 (comment)
Additional Information
The previous PR changed the zip library to be linked privately via object files into stable-diffusion. Because of this, the zip symbols are no longer exported transitively to the CLI example. Since image_metadata.cpp directly calls mz_uncompress, zip must be explicitly linked to the sd-cli target.
Checklist