Repository navigation
Conversation
The module shipped a JS unit test but no HttpCase runner, so it never ran in CI. Add the runner, and adapt the test to the 19.0 form layout: core now renders the form sheet + chatter side by side only at >= XXL (stacking them as `flex-column` below that), and the toggle is intentionally hidden in the stacked layout. The test now forces the wide/sided layout, mocks the chatter the same way mail compiles it, and asserts on the chatter's own state so it is deterministic regardless of test order or runner viewport.
Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
20.0-mig-web_toggle_chatter
branch
2 times, most recently
from
October 1, 2026 23:50
590a0e2 to
3fb25c1
Compare
* useState -> proxy (Owl 3). * fa- chevron -> oi + data-icon, in the template, the SCSS and the JS-built button. * __comp__ stays bare: 20.0 still passes it via t-call-context. * Tests: SIZES moved to @web/core/ui/ui_utils. Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
20.0-mig-web_toggle_chatter
branch
from
October 2, 2026 01:40
3fb25c1 to
d9ae65b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
web_toggle_chatterfrom19.0(OCA/web#3582, unmerged) to20.0. Follows the OCA migration guide.Two things a reviewer would not get from the diff:
owl3-migrationrewrote__comp__tothis.__comp__, which breaks the template. 20.0's compiler still emits it bare (views/view_compiler.js:189) and passes it throught-call-context, so it is a template variable, not a component member. Reverted.icon.className,querySelector(".fa")and theclassList.toggle("fa-angle-*")calls were converted by hand; otherwise the runtime fallback button renders a blank box.CI note:
test with Odoo/test with OCBare red on a core issue, not this module — OCA CI runs--skip-auto-install, which on 20.0 leaves core's ownweb.assets_frontendSCSS unbuildable (rgba($color, $alpha) must be a color). Reproduces on bare core with zero addons.AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.