Repository navigation
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: web-18.0/web-18.0-web_systray_button_init_action Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_systray_button_init_action/it/
Currently translated at 100.0% (1 of 1 strings) Translation: web-18.0/web-18.0-web_systray_button_init_action Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_systray_button_init_action/sl/
Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
20.0-mig-web_systray_button_init_action
branch
from
October 1, 2026 19:44
1785d6d to
87a41cc
Compare
* Dropped `test: true` from the tours: 20.0 validates registration with
t.strictObject({steps, url}), so an unknown key throws.
* Declared web_tour, previously present only via auto-install.
* QWeb bare identifiers -> this.showHomeButton / this.onClickInitAction.
* fa fa-lg fa-home -> oi oi-lg + data-icon="home".
* Dropped the unused useService("action").
Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
20.0-mig-web_systray_button_init_action
branch
from
October 2, 2026 01:40
87a41cc to
f523f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
web_systray_button_init_actionfrom19.0(OCA/web#3583, unmerged) to20.0. Follows the OCA migration guide.Two things a reviewer would not get from the diff:
tourRegistry.addValidation(t.strictObject({steps, url})), making thetest: truekey both tours carried an unknown key on a strict schema. No core 20.0 tour passes it.owl3-migrationrewritesuseService("action")tousePlugin(ActionManagerPlugin), importing a name that does not exist in 20.0 (the class isActionPlugin). Here the line was dead anyway, so it is gone rather than restored.CI note:
test with Odoo/test with OCBare red on a core issue, not this module — OCA CI runs--skip-auto-install, which on 20.0 leaves core's ownweb.assets_frontendSCSS unbuildable (rgba($color, $alpha) must be a color). Reproduces on bare core with zero addons.The tour test additionally cannot run under OCA CI:
web.assets_testsholds core'suser_switch_tour.js, which imports@bus/workers/websocket_worker, andbusis auto-install. Declaringbuswould make CI green but misrepresent the dependency, so it is left out; the behaviour was verified by hand on runboat instead.AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.