Fix datetime conversion failures observed with NumPy 2.5 - #344
Open
leowerneck wants to merge 1 commit into
Open
Conversation
leowerneck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #343
Description
This PR fixes datetime conversion failures observed with NumPy 2.5 by:
FILLVAL,VALIDMIN, andVALIDMAXmetadata on CDF time variables, preventing TT2000 overflow during xarray round trips.Testing
Running:
results in 82 passed, 25 skipped, 46 warnings. Running:
results in previously failing tests passing (though, admittedly, I am getting a couple of persistent
urllib.error.HTTPError: HTTP Error 429: Too Many Requestserrors locally).