docs: add ethlambda logo, banner and favicon - #616
Conversation
🤖 Codex Code Review
No consensus, fork-choice, attestation, STF, signature, or SSZ logic is touched here, so I did not find protocol-level correctness or security issues beyond the docs/CI concerns above. I could not run Automated review by OpenAI Codex · gpt-5.4 · custom prompt |
🤖 Kimi Code ReviewI'll review this PR focusing on the areas you specified. Looking at the diff, this PR primarily contains branding/documentation changes (logos, banners, workflow updates) rather than consensus-layer code changes. Let me analyze what's present. Files Changed Analysis1.
|
🤖 Claude Code ReviewReview: PR 616 — add ethlambda logo, banner and faviconThis is a docs/assets-only PR with no Rust code changes, so the consensus-layer review criteria (fork choice, attestations, STF, XMSS, SSZ) don't apply here. I verified the actual mechanics instead: Verified correct:
Minor/non-blocking observations:
Nothing here affects node behavior, and the described verification steps ( Automated review by Claude (Anthropic) · sonnet · custom prompt |
🗒️ Description / Motivation
What Changed
assets/— the source artwork.ethlambda_banner.pngandethlambda_logo.pngare the originals, untouched.ethlambda_logo_transparent.pngandethlambda_logo_notext.pngare derived: the black backdrop is removed by flood fill from the image border, and each one carries a 6 px opaque#000000halo so the art brings its own backdrop onto a light page.README.md— banner block at the top, 300 px wide.docs/introduction.md— the same banner block.docs/assets/ethlambda_banner.pngis a symlink to the repo asset rather than a copy: mdBook only copies files undersrc, but it does follow symlinks, so this avoids duplicating 680 KB.theme/favicon.svg— the site icon: a 128 px render of the creature on a transparent background, wrapped in an SVG. It is the only icon mdBook links..github/workflows/pr-main_mdbook.yml—theme/**added to both path filters, so a favicon-only change still triggers a Pages deploy.Correctness / Behavior Guarantees
ubuntu-latest), and GitHub's own markdown view ofdocs/introduction.mdserves the symlink blob rather than the image, so the banner renders in the book but not in that preview.theme/favicon.pngmeans a browser without SVG icon support falls back to its generic page icon.Tests Added / Run
make docs— clean, includingmdbook-linkcheck2underwarning-policy = "error".book/that the built site serves the banner byte-identical toassets/ethlambda_banner.png, and thatintroduction.htmlemits a singlerel="icon"link resolving to the emitted favicon.Related Issues / PRs
✅ Verification Checklist
No Rust was touched by this PR, so the workspace checks below were not run;
make docswas run instead.make fmt— cleanmake lint(clippy with-D warnings) — cleanmake test(cargo test --workspace --profile release-fast) — all passing