Introduce parsers - #1
Open
jozef-sabo wants to merge 14 commits into
Open
jozef-sabo wants to merge 14 commits into
jozef-sabo wants to merge 14 commits into
Conversation
Owner
|
Hello, thank you for your pull request. I am happy to see new commits here and that you have brought attention to the another file format :-) Couple of notes from my side:
What do you think? Is it worth rewriting the proposed changes and support for NDF files to pure python code without kaitai? And finally, I am just curious... is it related to your bachelor thesis or some school project? ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformat ESET
virlog.datfields extractor to an actual parser.Add new NDF parser.