Add editor.ui.k8s.appscode.com API group#653
Closed
tamalsaha wants to merge 1 commit into
Closed
Conversation
Add read-only aggregated API types EditorRender and EditorTemplate under a new editor.ui.k8s.appscode.com/v1alpha1 group: - EditorRender renders an editor model, manifest or resources from a set of options, without touching any existing installation. - EditorTemplate loads the editor model, manifest or resources for an existing installation identified by its metadata. These back the read-only editor endpoints served by kube-ui-server (which authorizes the resources touched as the API caller) and consumed by b3. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new read-only aggregated API group
editor.ui.k8s.appscode.com/v1alpha1with two create-only action kinds:/clusters/{owner}/{cluster}/helm/options/{model,manifest,resources}endpoints./clusters/{owner}/{cluster}/helm/editor/{model,manifest,resources}endpoints.Each kind carries a
Request/Responseand selects the artifact via anoutputdiscriminator (model|manifest|resources).Why
These types back the read-only editor endpoints served in-cluster by
kube-ui-server(which authorizes the resources touched as the extended-API caller, via impersonation) and consumed by b3. Apply/delete remain out of scope (read-only only).Generated
make genoutput: deepcopy, openapi, and clientset for the new group. Unrelated groups are untouched.Part of a 3-repo change: resource-metadata (types) → ui-server (registry/handlers) → b3 (consumption).