Revert "resolve SonarQube code convention issues and code smells" - #9
Merged
Merged
Conversation
There was a problem hiding this comment.
✅ Ready to approve
The diff is minimal, consistent with existing logger naming in the codebase, and does not introduce functional or behavioral changes.
Note: this review does not count toward required approvals for merging.
Pull request overview
This PR appears to revert a small subset of prior “SonarQube convention/code smell” adjustments by restoring the logger field naming and making a minor formatting-only tweak, without changing billing logic or output formatting.
Changes:
- Rename
LOGGERback tologgerinResidentialBillingEngineand update its usage. - Add a blank line inside
createBillRecord(formatting-only). - No functional change in
BillRecord(only a trailing brace line adjustment in the diff).
File summaries
| File | Description |
|---|---|
| OOP Mini Project/src/ResidentialBillingEngine.java | Restores logger identifier naming and adjusts a whitespace line in createBillRecord. |
| OOP Mini Project/src/BillRecord.java | No functional change; file ends with the closing brace as before. |
Copilot's findings
- Files reviewed: 1/2 changed files
- Comments generated: 0
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
finally everything is okey and good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8 - Accsidently added copilot to the pull request edit to revet that this pull request need to be revet....