Return errors for malformed metadata atoms#199
Conversation
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This would be better as separate changes. |
|
Split into three focused draft PRs as requested:
Closing this combined PR in favor of those independent changes. |
Fixes #179.
What changed
subscodec-specific parameters through the checked decoding path, returning an error for truncated input.irefbox sizes before slicing and constrain each reference decode to its declared box body.Error::MissingContentwhen encoding version 0 ormimeinfeentries without their required content type.subsdata, invalidirefsizes, and both invalidinfeencoder states.Why
These paths previously trusted attacker-controlled lengths or unwrapped optional fields. Malformed media could therefore panic, underflow, or loop instead of returning a normal parse/encode error.
The
ilocsize validation and unsupportedinfeversion 1 handling described in the issue were already fixed onmain; this PR addresses the remaining cases.Validation
cargo test --all-features(244 tests passed)cargo clippy --all-targets --all-features -- -D warningscargo fmt --allgit diff --check