Repository navigation
[BUGFIX] Ensure toolbox PDF download links exclusively target PDF files - #2190
Draft
beatrycze-volk wants to merge 1 commit into
Draft
beatrycze-volk wants to merge 1 commit into
beatrycze-volk wants to merge 1 commit into
Conversation
beatrycze-volk
force-pushed
the
pdf-download
branch
2 times, most recently
from
October 5, 2026 13:26
ac5eff9 to
1379368
Compare
Member
|
What is the reason for restricting downloads to PDF files? What's wrong with allowing any file format in the |
sebastian-meyer
self-requested a review
October 5, 2026 14:41
beatrycze-volk
force-pushed
the
pdf-download
branch
from
October 5, 2026 15:07
1379368 to
ea258a4
Compare
Adds a MIME type check to `getPageLink()` and `getWorkLink()` to guarantee that only `application/pdf` files are offered for download. This prevents generating download links for non-PDF files when a PDF is intended. Also refines warning messages and return values when no suitable PDF is found.
beatrycze-volk
force-pushed
the
pdf-download
branch
from
October 5, 2026 15:40
ea258a4 to
ed03e1f
Compare
Collaborator
Author
Restriction is introduced into PDF download tool. Currently this tool displays also images, what creates situation where image download tool gives link for an image and PDF download tool gives link for download linked to the same image file. |
beatrycze-volk
marked this pull request as draft
October 6, 2026 12:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a MIME type check to
getPageLink()andgetWorkLink()to guarantee that onlyapplication/pdffiles are offered for download. This prevents generating download links for non-PDF files when a PDF is intended.Also refines warning messages and return values when no suitable PDF is found.