文字結合プラグインライブラリ同梱#237
Open
juridon wants to merge 3 commits into
Open
Conversation
SilverRusk
approved these changes
Jul 2, 2026
SilverRusk
left a comment
Contributor
There was a problem hiding this comment.
LGTM。内容を確認し、問題ありませんでした。
確認結果
- CDN参照の置換: config.js の SweetAlert2(js/css)・JsRender を
thirdparties/に置換済み。CDN参照の残存なし - 同梱ファイルの同一性(SHA256): 公式CDNとバイト単位で完全一致
sweetalert2.min.js/sweetalert2.min.css= js.cybozu.com/sweetalert2/v11.23.0/ と一致jsrender.min.js= js.cybozu.com/jsrender/0.9.86/ と一致(ヘッダJsRender v0.9.86 (Beta))
- バージョン整合: manifest / README / 実ファイルすべて SweetAlert2 11.23.0 / JsRender 0.9.86 で一致
- version: 1.3.7 → 1.3.8
- README: 実態に合わせ訂正(旧 SweetAlert v1.1.3 の誤表記を SweetAlert2 11.23.0 へ、未使用の jQuery 削除、同梱パス追記)
同梱以外の変更について
- config.js の不具合修正(
ConFタイポ→CONF、判定を between フィールド基準に是正。v1.3.7 の jQuery 削除で発生した「項目間の記号」非表示の修正): 内容妥当 - package.sh 削除(textConnect のみに存在した旧・手動パッケージスクリプト、実行時依存なし): 妥当
同梱・バグ修正・スクリプト削除が1PRに混在していますが、いずれもPR説明に明記され内容も妥当なため、サンプルプラグインとして許容し Approve します。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ライブラリ同梱
※LGWAN 環境で外部 CDN に依存しないようにするための修正
thirdparties/に同梱不具合修正
。