Use kernelkit/goyang instead of patched builtin#1541
Merged
Conversation
The three YANG 1.1 fixes lived as a frozen, one-shot copy of goyang v1.6.3 under internal/goyang (via a local `replace`) — invisible to dependency/CVE tracking and impossible to update. Move them to the maintained kernelkit/goyang fork (v1.6.3-kkit branch) and depend on it through go.mod, pinned by commit hash; drop the in-tree copy. getopt falls out of the dependency set since it was only used by goyang's CLI, not pkg/yang. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
changed the title
mattiaswal
reviewed
Jun 18, 2026
| } | tee -a "$GITHUB_STEP_SUMMARY" | ||
|
|
||
| # Gate only on vulnerabilities our code actually calls in a | ||
| # dependency. Called stdlib vulns are fixed by bumping the |
Contributor
There was a problem hiding this comment.
Does this handle indirect usage as well? If we use a function that uses something bad?
Contributor
Author
There was a problem hiding this comment.
The comment is a bit vague, govulncheck actually reaches any vulnerable symbol in the call graph. I've updated the comment.
Add govulncheck CI and Dependabot for the two Go modules, src/webui and src/netbrowse, so vendored dependencies don't quietly accumulate CVEs between manual updates. The workflow reports every finding in the run summary but only fails on vulnerabilities our code actually calls in a dependency. Called stdlib vulnerabilities are surfaced too, but they're fixed by bumping the Buildroot host Go rather than a module's go.mod, so they don't gate the build. Dependabot ignores openconfig/goyang: it's pinned to our kernelkit fork via a replace directive and stepped by hand. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
web-vendoring
branch
2 times, most recently
from
84f83ec to
a365238
Compare
mattiaswal
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor, or cleanup, of one of the new webui's dependencies. This drops the locally patched "fork" of goyang with the same open pattern used by KernelKit for other deps.
Checklist
Tick relevant boxes, this PR is-a or has-a: