auto-resolve sso provider icons via simple icons#8
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR modifies SSO provider icon handling in the UI layer, not kernel API endpoints or Temporal workflows as specified in the filter. To monitor this PR anyway, reply with |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
useEffect runs after paint, so when the provider prop changes the first render still sees errored=true and briefly shows the letter avatar. Tracking the errored slug directly makes the check happen during render.
…lback Keep multicolor inline SVGs for Google, GitHub, GitLab, Microsoft, Facebook, and Apple. Fall back to Simple Icons CDN for any other provider, with a letter avatar as the final fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 65cc025. Configure here.
dcruzeneil2
left a comment
dcruzeneil2
left a comment
There was a problem hiding this comment.
LGTB (looks good to bufo)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 participants
Summary
Replaces the hardcoded provider switch in
getSSOProviderInfowith a generic resolver, so any provider key works out of the box — no more per-provider PRs.provideris slugified (google,github,okta,auth0,discord,slack, etc.).https://cdn.simpleicons.org/<slug>) via a regular<img>— 3000+ brands, MIT, no API key, no bundle cost.<img>error, falls back to a circular letter avatar with the provider's first letter — so unknown providers still render something.passkey,sso,saml) keep their existing built-in icons.GoogleMark/GitHubMark/GitLabMark/MicrosoftMark/FacebookMark/AppleMarkSVGs fromicons.tsx— net-22lines and a smaller bundle.Trade-offs
simple-iconsnpm package with dynamic import.Test plan
bun run typecheckpassesNote
Medium Risk
Changes SSO provider icon rendering to fetch icons from an external CDN at runtime, which could impact UI reliability/performance if the CDN fails or is blocked. Logic changes are localized to provider display but alter labels and icon selection behavior for all SSO buttons.
Overview
SSO provider display is generalized:
getSSOProviderInfonow slugifies provider strings, uses a small built-in map for common/non-brand providers, and otherwise loads brand icons fromhttps://cdn.simpleicons.org/<slug>.When the CDN icon fails (or the provider can’t be slugified), the UI falls back to a circular letter avatar and provider labels are derived via
titleCase(). Styling addskma-sso-icon--letter, andGitLabMarkis added toicons.tsxto support the built-in provider set.Reviewed by Cursor Bugbot for commit f04a26f. Bugbot is set up for automated code reviews on this repo. Configure here.