Enable Form content matching on ReadOnlyMemoryContent - #1141
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 15 15
Lines 896 896
Branches 205 205
=======================================
Hits 890 890
Misses 4 4
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends form-url-encoded body matching in HttpRequestInterceptionBuilderExtensions.ForFormContent(...) to support ReadOnlyMemoryContent when targeting .NET 8+ (guarded by NET8_0_OR_GREATER), and updates the repository’s pinned .NET SDK patch version.
Changes:
- Allow
ForFormContent(...)matching when requestHttpContentisReadOnlyMemoryContenton .NET 8+. - Keep existing behavior for pre-.NET 8 builds (only
ByteArrayContent-based bodies are eligible for matching). - Bump
global.jsonSDK from10.0.301to10.0.302.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/HttpClientInterception/HttpRequestInterceptionBuilderExtensions.cs | Adds a .NET 8+ conditional to treat ReadOnlyMemoryContent as eligible for form-body matching. |
| global.json | Updates pinned .NET SDK patch version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+395
to
+406
| #if NET8_0_OR_GREATER | ||
| // FormUrlEncodedContent derives from ByteArrayContent so use the | ||
| // least specific type for more flexibility (e.g. also StringContent). | ||
| // ReadOnlyMemoryContent is also supported as the underlying content is a ReadOnlyMemory<byte> | ||
| // which can be copied to a MemoryStream for parsing. | ||
| // Other content types are not supported as they may be iterating over | ||
| // a stream which might not support arbitrary seeking if the request | ||
| // is not a match and needs to be sent to the URL originally specified. | ||
| if (content is not ByteArrayContent && content is not ReadOnlyMemoryContent) | ||
| { | ||
| return false; | ||
| } |
slang25
approved these changes
Jul 28, 2026
hwoodiwiss
force-pushed
the
improve-form-content-matching
branch
from
July 28, 2026 14:56
ec29576 to
e687e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.