Skip to content

Week 1-2: ANG-001, ANG-002, ANG-003#5

Open
yugalkaushik wants to merge 25 commits into
masterfrom
dev
Open

Week 1-2: ANG-001, ANG-002, ANG-003#5
yugalkaushik wants to merge 25 commits into
masterfrom
dev

Conversation

@yugalkaushik

Copy link
Copy Markdown
Collaborator

No description provided.

@yugalkaushik yugalkaushik changed the title Week 1: ANG-001, ANG-002, ANG-003 Week 1-2: ANG-001, ANG-002, ANG-003 Jun 18, 2026
Comment thread src/data/NoteRepository.ts Outdated
Comment thread src/data/NoteRepository.ts Outdated
@malekhavasi

malekhavasi commented Jun 21, 2026

Copy link
Copy Markdown

A couple of small suggestions that could improve the PR:

  • Could we add some documentation for the public methods? A short comment above each method explaining what it does and what it returns would be enough. It doesn't need to be detailed, just enough so someone can understand the purpose without reading the implementation
  • There are several empty .ts files (for example, GraphBuilder.ts, VectorDatabase.ts, and OllamaProvider.ts). I think it would be better to add these files only when they contain some implementation. This helps keep the repository clean and avoids giving the impression that these parts are already implemented

Comment thread src/data/NotePreprocessor.ts
Comment thread src/data/LinkExtractor.ts
ANG-004: Structural note graph with Cytoscape.js + fCoSE webview rendering
@yugalkaushik yugalkaushik requested a review from malekhavasi June 22, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants