Skip to content

[1st · merge first] Stop linking seller names to a JoomPulse page that does not exist - #41

Open
fiharet34 wants to merge 1 commit into
joomcode:mainfrom
fiharet34:fix/no-seller-joompulse-link
Open

fiharet34 wants to merge 1 commit into
joomcode:mainfrom
fiharet34:fix/no-seller-joompulse-link

Conversation

@fiharet34

@fiharet34 fiharet34 commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Merge this before #35. #35 contains this commit, merged in to resolve a clash on the same passages. Landing this one first keeps #35's diff to its own work. If #35 lands first, it must use a merge commit rather than squash — a squash rewrites the SHA, so git replays this diff against changed text and conflicts even though the content is already in main.

The Vendedor name linked to a seller's JoomPulse page. Sellers have no such page: the dashboard link template is for listing ids only, so a URL built from a shopId 404s.

The name is now plain text, and the skill's description no longer promises a link per seller.

🤖 Generated with Claude Code

pulse://overview rule 10 restricts the beginner-products/{id} template to
listing ids and skips seller grain. This skill asks for the Vendedor name to
link to "the seller's JoomPulse page". In a live run every one of those links
was built from a shopId and 404ed — nine dead URLs in a single answer.

Two places were promising it:

- the presentation rule in the body, which now states the name is plain text
  and why;
- the frontmatter description, which advertised "...listing-type counts, with
  a JoomPulse link each". That one matters more than it looks: descriptions
  are injected into the system prompt for skill selection, so the promise
  shipped even in conversations where this skill never loaded.

Nothing else changes — no column, threshold or ranking rule is touched.
@fiharet34
fiharet34 force-pushed the fix/no-seller-joompulse-link branch from e48a332 to 0cf23ab Compare September 11, 2026 11:05
fiharet34 pushed a commit to fiharet34/joompulse-skills that referenced this pull request Sep 14, 2026
Both branches rewrote the same two passages. Resolved by keeping this branch's
fuller field list and its added guidance, and taking joomcode#41's correction throughout:
sellers have no JoomPulse page, so the Vendedor name is plain text and the
description no longer promises a link per seller.

Merging it here rather than leaving the clash for whoever lands these second.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@fiharet34
fiharet34 marked this pull request as ready for review September 14, 2026 12:58
@fiharet34 fiharet34 changed the title Stop linking seller names to a JoomPulse page that does not exist [Merge first] Stop linking seller names to a JoomPulse page that does not exist Sep 14, 2026
@fiharet34 fiharet34 changed the title [Merge first] Stop linking seller names to a JoomPulse page that does not exist [1st · merge first] Stop linking seller names to a JoomPulse page that does not exist Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant