[any order] Fix growing-leaf-category-tracker: show the number the ranking is built on, and stop the floor moving between runs - #36
Open
fiharet34 wants to merge 1 commit into
Conversation
…lt on, and stop the floor moving between runs The skill ranked niches by month-over-month growth and was forbidden from displaying it - Output said "exactly these five columns ... not a displayed column" while Presentation rules prescribed a header for that column and the panel required the growth figure on a card. On a text surface it appeared nowhere: one run showed fifteen rows with the leader called "o maior salto" and no percentage anywhere. Both growth columns are now displayed. The size floor was invented per run. Two runs on one category, minutes apart, chose R$ 1.000.000 and R$ 300.000, and the second run's leader sat below the first run's floor - so the same question returned a different top niche. The floor is now the greater of R$ 300 mil and 0,02% of the parent category's estimated monthly revenue, which is stated in the output. A fixed figure cannot serve both marketplaces: Mercado Livre ranks deep leaf niches, Shopee ranks whole level-3 categories. Also: revenue and unit growth read together, since a niche can grow revenue while selling fewer units; concentration and revenue per seller as columns, and seasonality as a Mercado Livre reading only, because Shopee carries none; identifier-based navigation on both marketplaces, replacing a per-category link that does not resolve; full money precision on Mercado Livre with Shopee exempt, its figures being rebuilt from rounded counters; exact coverage counts; a category-specific disclaimer with the monthly lag; retry after a pause; and an empty result separated from an outage.
fiharet34
pushed a commit
to fiharet34/joompulse-skills
that referenced
this pull request
Sep 10, 2026
The portal was pinned to a 20 August baseline of this skill, so the manual pass flagged the missing ranking figure and then withdrew it against text that said never present a change. joomcode#36 is that fix, already open upstream.
fiharet34
marked this pull request as ready for review
September 14, 2026 12:58
fiharet34
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine defects in
growing-leaf-category-tracker, each reproduced against production data and re-verified.1. The ranking metric was forbidden from appearing — the answer ranked by a number it was not allowed to show.
2. The size floor was invented per run, so the same question gave different niches on different days. Now relative to the parent category, and stated in the answer.
3. Ranking on revenue growth alone recommended contracting niches — four of twenty grew revenue while unit sales fell, which is price movement, not demand.
4. The per-category link does not exist. Categories have no JoomPulse page; a URL built from a categoryId 404s.
5. Wrong class of estimate disclaimer, and no lag stated. Category figures are a different estimate from listing figures, and can trail by up to ~31 days.
6. The readings that decide entry were absent — concentration and revenue per seller, without which a "fast grower" cannot be judged enterable.
7. Retry with no backoff, ignoring an explicit 60-second retry hint.
8. An empty result was indistinguishable from an outage.
9. One page of the tree was presented as the whole category — a query returns at most one page, which was never said.
Merges cleanly with
mainand with every other open PR in this set.🤖 Generated with Claude Code