Migrate TCK userguide from jbake to asciidoc - #420
Merged
Merged
Conversation
Member
Author
|
@m0mus Would you be able to review this? |
KyleAure
reviewed
Sep 10, 2026
KyleAure
left a comment
Member
There was a problem hiding this comment.
Thanks for taking this on. Just some minor comments.
Assisted-by: IBM Bob 2.1.0
Member
Author
|
I updated the JavadocAssertions to md, and merged the release notes and index.html into a single ReadMe.md. I also moved the pom.xml to the root of the folder and moved the ReadMe and JavadocAssertions so they're in the correct relative positions in the filesystem and final zip folder. |
KyleAure
approved these changes
Sep 11, 2026
m0mus
previously approved these changes
Sep 16, 2026
m0mus
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JBake plugin in use was old enough that it didn't support ARM based Macbooks. Updating the plugin caused other issues, so I decided to move from jbake to asciidoc, which is already in use in this repository for other documents, and is used extensively for other Jakarta Specification documents. This simplifies and speeds up the TCK build process, and should make maintenance of the userguide easier.
This PR covers:
Here's the docs folder of the tck since that's the easiest way to see the end result:
docs.zipUpdated from Kyle's suggestions: docs.zip