Repository navigation
fix: allow runtime upgrades with passthrough WebSockets - #227
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Codex WebSocket turn routing is off or observe, the proxy has no terminating broker. Homebrew reinstall previously rejected this valid runtime as unsupported, despite worker admission tracking ordinary requests and passthrough sockets until their handlers return. Allow that nil-broker path to drain before handoff; keep unknown custom brokers rejected.
Also accept grouped uninstall declarations in the quarantine validator and report the persisted deferral code in CLI and native CI failures.
Validation: regression tests failed before the repair and passed afterward with -race; focused proxy tests (3.273s), full CLI race tests (38.111s), build/vet and shell syntax passed. Required full race CI 37935902610 passed. Native CI 37935906815 passed all jobs, including actual macOS Cask upgrade, same-PID reinstall, HTTP/SSE and WebSocket transport, genuine uninstall cleanup, quarantine handling, Linux AMD64/ARM64 race suites and Windows MSI lifecycle. Independent review found no actionable P1/P2 issues.