Repository navigation
fix: keep Homebrew callback setup with its declaration - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting a complete GoReleaser cask moved its uninstall declaration after callback setup. Loading the resulting package then failed because the uninstall artifact did not exist yet. Native package CI caught this before release tagging or publication.
Attach callback setup to the uninstall declaration with
tap, so formatting preserves their evaluation order. Expand the native regression envelope to match GoReleaser's custom-block-first layout and full architecture/metadata stanzas. Keep the existing upgrade, reinstall and genuine uninstall assertions after saving and reloading Ruby metadata.Validation: full downloaded cask formats cleanly and passes actual metadata save/reload and callback checks. Four native callback race tests, focused provenance race tests, build and vet pass. Rerun manual native package CI before release tagging.