Fix toolbar shifting when inventory has items - #7
Merged
Conversation
The Farmer_shiftToolbar_Prefix function intercepts the toolbar shifting logic to allow configuring how many rows are shifted. This function checks many conditions to decide when to execute, including whether the inventory has items in it. Checking the number of actual items is incorrect, as it prevents shifting the toolbar when there are any items. We could invert the check to only execute if there is at least one item. Instead, just remove this check and shift regardless of whether there are items in the inventory. While at it, split the conditions over multiple lines, and re-arrange the order so that we check __instance.Items for null prior to attempting to access it, as reported by Copilot. Fixes #5 Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
jacob-keller
force-pushed
the
jk-fix-shift-with-items
branch
from
July 27, 2026 23:39
9240435 to
d9e9e8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Farmer_shiftToolbar_Prefix function intercepts the toolbar shifting
logic to allow configuring how many rows are shifted. This function
checks many conditions to decide when to execute, including whether the
inventory has items in it.
Checking the number of actual items is incorrect, as it prevents
shifting the toolbar when there are any items. We could invert the check
to only execute if there is at least one item. Instead, just remove this
check and shift regardless of whether there are items in the inventory.
Fixes #5
Signed-off-by: Jacob Keller jacob.keller@gmail.com