Avoid using checkHeldItem() to improve android compatibility - #4
Merged
Conversation
The Android version of the game apparently does not have the checkHeldItem() function in its InventoryPage. This function checks if CursorSlotItem is null, but optionally takes a function to test the currently held item with. We never use the function, and just use it to check whether there is any held item. Instead of using the function, replace the code to simply directly check of Game1.player.CustorSlotItem is not null. This removes one incompatibility with the Android version of the game. While at it, convert the hoverText checks to use IsNullOrEmpty as pointed out by YourJeiJi. Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR removes usage of InventoryPage.checkHeldItem() (which is missing on Android) in FullInventoryPage by directly checking whether the player is holding a cursor item, improving cross-platform runtime compatibility. It also simplifies hover text emptiness checks using string.IsNullOrEmpty.
Changes:
- Replaced
checkHeldItem(null)calls withGame1.player.CursorSlotItem != null. - Updated hover text condition from
hoverText != null && !hoverText.Equals("")to!string.IsNullOrEmpty(hoverText).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android version of the game apparently does not have the
checkHeldItem() function in its InventoryPage. This function checks if
CursorSlotItem is null, but optionally takes a function to test the
currently held item with.
We never use the function, and just use it to check whether there is any
held item. Instead of using the function, replace the code to simply
directly check of Game1.player.CustorSlotItem is not null. This removes
one incompatibility with the Android version of the game.
While at it, convert the hoverText checks to use IsNullOrEmpty as
pointed out by YourJeiJi.
Signed-off-by: Jacob Keller jacob.keller@gmail.com