Remove more deprecated android code and unify openal settings#2776
Remove more deprecated android code and unify openal settings#2776riccardobl wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request unifies the OpenAL audio renderer settings across platforms by introducing a new OPENAL constant in AppSettings and deprecating platform-specific constants like LWJGL_OPENAL and ANDROID_OPENAL_SOFT. It also removes the com.jme3.view.surfaceview package and simplifies the Android harness by removing the configureSettings and createSettings hooks. Review feedback identifies a functional regression in JmeFragment where example settings are no longer applied, logic inconsistencies and outdated log messages in JmeAndroidSystem, and a potential NullPointerException in JmeDesktopSystem.
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
2 participants
This PR removes the old untested android surface based path and unifies the LWJGL and android OpenAL AppSetting to simply AppSetting.OPENAL, then removes the createSettings in android fragment, that is now useless.
The goal is to let the developer use the same SimpleApplication creation pattern used in the desktop backend