chore(frames-first): shrink uncovered residual 116→58, exclude app infra - #734
Merged
Conversation
Second frames-first coverage pass, completing the classification of the
uncovered surface toward a safe warn→fail flip.
- nonFeaturePaths: add the structural app infra that can never have frames —
frontend/src/{contexts,lib,platform,services,utils}, App.tsx, index.css,
packages/*-ui/src/test/**, **/.gitattributes. These are non-rendering
plumbing, not feature screens (kept tight per the policy's warning).
- Map real code to features (point-at-reality): auth-ui → the approved
auth-experience feature (frames planned the never-built auth-experience-ui);
the config/org/billing/member/employee page-wrappers → their features.
auth-experience build.packages corrected to @fuzefront/auth-ui.
- Re-stamped the 7 edited manifests (implementation.paths is part of the hash).
- ratchet.knownUncovered reduced to the precise NAMED residual: chat-ui (no
frames at all), identity invites/ + common/page shells, and the frontend
app shell (6 pages + components). Each now needs a per-item owner decision
(author a frame, or declare structural), not a mechanical mapping.
- uncovered.mode stays "warn": the flip would still fail any PR touching the
58 genuinely-unframed files (chat-ui foremost), so it is not yet safe.
gate-frames-first: OK (this PR changes no feature UI). All 21 stamps clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0127R9Zcw92tmBkxUUuLEB79
Contributor
Automated code review (gate-code-review)Credit balance is too low Report-only — this check never blocks merge. |
Contributor
Automated code review (gate-code-review)Credit balance is too low Report-only — this check never blocks merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Second frames-first coverage pass (follow-on to #717), completing the classification of the uncovered UI surface so the
warn → failflip becomes a small, named decision rather than a vague 100+-file cliff. Part of task #7's follow-through.Uncovered feature-UI files: 290 → 116 (#717) → 58 (this PR).
🔄 Type of Change
nonFeaturePaths+implementation.paths+ policy ratchetNo runtime/API/UI behavior changes.
gate-frames-first: OK— this PR changes no feature UI (onlydesign/frames/**/manifest.json+governance/), so there is no BLOCKED risk.🔧 Implementation Details
Changes Made
nonFeaturePaths— exclude structural app infra that can never have frames:frontend/src/{contexts,lib,platform,services,utils},App.tsx(router table),index.css,packages/*-ui/src/test/**,**/.gitattributes. Non-rendering plumbing, not feature screens — kept deliberately tight per the policy's "over-excluding guts the gate" warning (the rendering shell is not excluded; it stays in the named residual for an owner call).packages/auth-ui/src/**+LoginPage.tsx→ the approvedauth-experiencefeature. The frames planned a never-builtauth-experience-ui; the code actually lives inauth-ui.build.packagescorrected to@fuzefront/auth-ui. This removesauth-uifrom the flip blockers.config/org/billing/member/employeepage-wrappers underfrontend/src/pages/**→ their respective features.implementation.pathsis part of the content hash; approval keys are excluded, so existingapprovedflags are undisturbed). All 21 stamps clean.ratchet.knownUncoveredreduced to the precise NAMED residual:chat-ui(no frames at all), identityinvites/+ sharedcommon/pageshells, and thefrontend/srcapp shell (6 pages — Dashboard/Admin/Help/Status/Test/AcceptInvite — plus the shell/guard components). Each now needs a per-item owner decision (author a frame, or declare structural), not a mechanical mapping.Why
uncovered.modestayswarnFlipping to
failwould still fail the next PR touching any of the 58 genuinely-unframed files —chat-uiforemost (zero frames), and the app-shell components which need a one-time "is shell chrome feature UI or structural?" call from the owner. So the flip is not yet safe; the policy now documents the exact short worklist. Owner:@izzywdev.🧪 Testing
node scripts/stamp-frames.mjs --check→ all 21 stamps up to date.node --test scripts/__tests__/stamp-frames.test.mjs→ 3/3 (algorithm pin intact; account-security unchanged this pass).node scripts/check-frames-first.mjs --base origin/master→gate-frames-first: OK(0 feature-UI files changed).node scripts/check-frames-first.mjs --report-uncovered→ 58 (down from 116).governance/frames-first-policy.jsonparses as valid JSON.🚨 Breaking Changes
None.
🤖 Generated with Claude Code
Generated by Claude Code