fix(ci): make the API-key Seal Twilio + SMS workflow runnable - #693
Merged
Conversation
master's seal-sms-secrets.yml adopted Twilio API-key auth (TWILIO_API_KEY_SID / TWILIO_API_KEY_SECRET) but still pinned azure/setup-kubectl to a SHA GitHub cannot resolve, so the job dies at "Set up job" before any step runs. This keeps the API-key model and applies the runnable-infra fix: - Drop azure/setup-kubectl + kubectl entirely: build the input Secret manifest inline (base64 data:) and pipe to kubeseal --merge-into. No action pin to break. - Fetch the sealed-secrets PUBLIC cert over HTTPS from CERT_URL (same source as deploy/scripts/seal-secret.sh) — no KUBE_CONFIG / cluster access. - Commit to master via the RELEASE_BUMP_SSH_KEY deploy key (a bypass actor on the "Protect Master" ruleset, as release.yml's GitOps bump does); a plain GITHUB_TOKEN push 409s. Seals exactly the secretKeyRefs sms-service.yaml mounts: TWILIO_ACCOUNT_SID, TWILIO_API_KEY_SID, TWILIO_API_KEY_SECRET, TWILIO_VERIFY_SERVICE_SID, and the minted SMS_AUTH_SECRET. Guards unchanged; sms-service stays enabled: false. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hc8XVgyLJkyeMsRysJYCqP
izzywdev
force-pushed
the
claude/multi-service-dockerfile-deps-uzgczg
branch
from
August 17, 2026 15:31
4b52ee2 to
79b0f09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
master'sseal-sms-secrets.ymladopted Twilio API-key auth (TWILIO_API_KEY_SID/TWILIO_API_KEY_SECRET, preferred over the account Auth Token) — but still pinsazure/setup-kubectlto a SHA GitHub can't resolve, so the job dies at "Set up job" before any step runs (Unable to resolve action azure/setup-kubectl@3e0aec4d…). This keeps the API-key model and applies the runnable-infra fix.🔧 What changed (one file:
.github/workflows/seal-sms-secrets.yml)kubectl+ the brokenazure/setup-kubectlaction. The input Secret manifest is built inline (base64data:) and piped tokubeseal --merge-into— no action pin to break.CERT_URL(same source asdeploy/scripts/seal-secret.sh) instead of a cluster fetch — noKUBE_CONFIG/ cluster access.mastervia theRELEASE_BUMP_SSH_KEYdeploy key — a bypass actor on the "Protect Master" ruleset, asrelease.yml's GitOps bump does. A plainGITHUB_TOKENpush 409s.Seals exactly the
secretKeyRefssms-service.yamlmounts:TWILIO_ACCOUNT_SID,TWILIO_API_KEY_SID,TWILIO_API_KEY_SECRET,TWILIO_VERIFY_SERVICE_SID, and the mintedSMS_AUTH_SECRET. Guards unchanged;dry_runpreviews without committing.🧪 Testing
Require Twilio credentialsguard, which fails by design until the fourTWILIO_*repo secrets are set. No commit on a dry run.secretKeyRefs exactly.📝 Notes
TWILIO_ACCOUNT_SID/TWILIO_API_KEY_SID/TWILIO_API_KEY_SECRET/TWILIO_VERIFY_SERVICE_SIDas repo secrets, then dispatch.sms-servicestaysenabled: false.seal-consumer-secret.yml(behind anif:skip) — separate cleanup.