Add items for OSRB - #52
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded contribution, contributor, license, and security documentation. ChangesGovernance documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 15-21: Update the fenced code blocks in the commit-signing
documentation by adding blank lines before and after each fence, including the
blocks showing the git commit command and resulting Signed-off-by line. Preserve
the existing text and formatting inside the fences.
- Line 19: Update the fenced code blocks in CONTRIBUTING.md that contain the
sign-off message, DCO version text, and DCO certification text by adding the
text language identifier to each opening fence, while leaving their contents
unchanged.
- Line 6: Update the “Signing Your Work” heading in CONTRIBUTING.md from h4 to
h3 so it follows the preceding h2 heading sequentially.
In `@CONTRIBUTORS.md`:
- Line 10: Add a blank line immediately after the “Core Team” heading, matching
the spacing used after the “Contributors” heading before its list.
In `@LICENSE.md`:
- Around line 1-2: The README file contains links that reference a missing
LICENSE file, but the actual license file is named LICENSE.md. Update both the
license badge link and the Apache License 2.0 text link in the README to point
to LICENSE.md instead of LICENSE to ensure they resolve to the correct file.
In `@SECURITY.md`:
- Around line 14-18: Normalize the indentation of the nested list items under
“Please include the following information” in SECURITY.md by changing the
inconsistently indented entries to the expected four-space indentation,
preserving their text and list structure.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 171ed2e6-79f5-4bc6-9ddd-e34229fa59a4
📒 Files selected for processing (4)
CONTRIBUTING.mdCONTRIBUTORS.mdLICENSE.mdSECURITY.md
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 92-97: Restrict the NVIDIA NGC login step near the Docker-based
test flow to trusted refs or a protected environment so pull-request code cannot
access NGC_API_KEY through the runner’s Docker configuration. Update the
workflow gate and the `docker/login-action@v3` step consistently, preserving
image pulls for trusted runs while preventing modified pull-request tests from
executing after credentialed login.
In @.github/workflows/nightly.yml:
- Around line 64-69: Restrict the test_full job before the NVIDIA NGC login step
to trusted execution contexts, so workflow_dispatch runs from untrusted refs
cannot access secrets or run scripts after authentication. Update the job
condition around test_full to allow scheduled runs only, or require a protected
environment and explicitly restrict manually selected refs before using
NGC_API_KEY.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: e9fc764a-c9f8-4e10-9c96-0adf8bf3d7db
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/nightly.yml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 68-69: Update the job setup preceding docker/login-action to write
the temporary Docker configuration path based on the runtime $RUNNER_TEMP
variable into $GITHUB_ENV, then remove the job-level runner.temp-based
DOCKER_CONFIG assignment so the login action receives the exported value.
Preserve the run-specific isolation suffix and do not use github.workspace.
In @.github/workflows/nightly.yml:
- Around line 36-37: Update the workflow’s job-level environment by removing the
DOCKER_CONFIG assignment that references runner.temp. Add an initial setup step
that constructs the same run- and attempt-specific Docker config path from
$RUNNER_TEMP and persists it through $GITHUB_ENV for subsequent steps.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 1e9c428c-10c2-41b5-a224-4e735c6c85dc
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/nightly.yml
3 tasks
steple
approved these changes
Aug 4, 2026
njawale42
approved these changes
Aug 5, 2026
njawale42
left a comment
njawale42
left a comment
Collaborator
There was a problem hiding this comment.
Lgtm, a minor spelling mistake to be addressed
peterd-NV
added a commit
that referenced
this pull request
Aug 5, 2026
* Log in to NGC before GPU Docker builds that pull isaac-sim. (#53) (cherry picked from commit 406e970) * Add items for OSRB (#52) * add security.md * add contributing and update license to license.md * fix ngc login * remove ngc login step from ci yaml * add ngc login step, ignore any potentailly stale credentials on runner * fix ci yaml syntax * revert login change * update contributors.md * fix license.md year (cherry picked from commit 056ea61) --------- Co-authored-by: hguillen <hguillen@nvidia.com>
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing items for OSRB:
Summary by CodeRabbit