run analyser as chain node#120
Open
huangzhiran wants to merge 3 commits intov1from
Open
Conversation
envestcc
reviewed
Jan 22, 2026
envestcc
reviewed
Jan 22, 2026
envestcc
reviewed
Jan 23, 2026
envestcc
reviewed
Jan 23, 2026
envestcc
reviewed
Jan 27, 2026
| cs := srv.ChainService(config.Default.ChainConfig.Chain.EVMNetworkID) | ||
| dao := cs.BlockDAO() | ||
| bdao = kernel.NewLocalBatchBlockDao(dao) | ||
|
|
Member
There was a problem hiding this comment.
In p2p mode, L355 does not need to be executed again, as it will automatically synchronize blocks from the network.
As for L346, I'm not sure if running Start again would cause any issues. You should verify this, but it likely also does not need to be executed again.
envestcc
reviewed
Jan 27, 2026
| BlockDB Blockdao `yaml:"blockDB"` | ||
| Log log.GlobalConfig `yaml:"log" json:"-"` | ||
| SubLogs map[string]log.GlobalConfig `yaml:"subLogs" json:"-"` | ||
| Genesis genesis.Genesis `yaml:"genesis"` |
Member
There was a problem hiding this comment.
As discussed, the genesis configuration can be treated as a standalone configuration file. We can first note a TODO for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.