fix(segment): use a single roving tab stop - #31529
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
|
@minwookshin is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30022
What is the current behavior?
Every segment button is a Tab stop, so entering the segment misses the selected button and Tab cycles through the group.
What is the new behavior?
The selected enabled button is the entry point, falling back to the first enabled button. Arrow-key focus remains separate from selection in manual activation mode, and Tab/Shift+Tab leave the group. The tab stop updates when buttons change, become disabled, or reconnect.
Does this introduce a breaking change?
Other information
Confirmed the new keyboard regression fails before the fix. Verified 54 Playwright checks across Chromium, Firefox and WebKit, iOS/MD styles and LTR/RTL; the Stencil spec run passed 87 suites / 794 tests. Build and targeted ESLint/Prettier checks passed.
#31431 handles ARIA position/count separately; this change is limited to keyboard tab stops. Browser tests use emulated viewports, not physical iOS devices.