Conversation
An outlet whose single route renders a plain <Routes> keeps one view item and swaps a new IonPage into it on every navigation. Each new page mounts with ion-page-invisible, but the duplicate-transition guard only compared view ids, so from the second root navigation (or the second push under a bare "*" route) the transition was skipped and the page stayed invisible. Compare the entering IonPage element as well, so a newly mounted page gets its transition, reveal and lifecycle events. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@djoume is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31525
What is the current behavior?
When an outlet's only route is a splat whose element renders
<Routes>, every navigation swaps a newIonPageinto the same view item. Each new page mounts withion-page-invisible.isDuplicateTransitioncompares only the entering and leaving view ids, so the swap looks like a repeat of the previous transition and is skipped. The page stays atopacity: 0, which leaves a blank screen. This happens:path="/*";path="*".What is the new behavior?
lastTransitionalso records the enteringIonPageelement, and a transition only counts as a duplicate when that element is the same too. A newly mounted page now takes the normaltransitionPagepath, so it is revealed and fires its lifecycle events. A second call for the same navigation, with the same element, is still skipped.root-single-viewtest app, served under its own basename likeroot-splat-sibling, androot-single-view.spec.ts:/*: three root navigations each leave the target page visible;*(?splat=bare): three pushes each leave the target page visible.Does this introduce a breaking change?
Other information
StackManagerchange, and passes with it.reactrouter6-react18passes the full Playwright suite (127/127) and the full Cypress suite (206/206).npm run typecheckandnpm run lintare clean.tab-lifecycle.spec.ts(FW-6788), because returning tabs needtransitionPageto fireionViewDidEnter. Fixing the duplicate check keeps that path.