Skip to content

docs(contributing): update screenshot commands and Docker usage - #31441

Merged
brandyscarney merged 3 commits into
mainfrom
docs/contributing-screenshots
Sep 28, 2026
Merged

brandyscarney merged 3 commits into
mainfrom
docs/contributing-screenshots

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Updated the contributing guide to replace the outdated commands (npm run test.screenshot) with the current commands: npm run test.e2e.docker.update-snapshots and npm run test.e2e.docker.

Also moved most of the explanation into the proper testing files and link to it instead of having it in the main contributing guide. Restructures the steps for running tests and removes old Docker instructions.

@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Sep 17, 2026 5:57pm UTC

Request Review

@brandyscarney
brandyscarney marked this pull request as ready for review September 11, 2026 19:00
@brandyscarney
brandyscarney requested a review from a team as a code owner September 11, 2026 19:00
@brandyscarney brandyscarney changed the title docs(contributing): update with correct screenshot commands docs(contributing): update screenshot commands and Docker usage Sep 11, 2026
Comment thread docs/core/testing/usage-instructions.md Outdated
Comment thread docs/CONTRIBUTING.md

@thetaPC thetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney
brandyscarney added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit 5bfbc7f Sep 28, 2026
101 of 103 checks passed
@brandyscarney
brandyscarney deleted the docs/contributing-screenshots branch September 28, 2026 17:30

This branch was successfully deployed

1 active deployment
Preview — c352490e Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants