chore(styles): remove ion-icon and share the arrow mask mixin - #4703
Open
thetaPC wants to merge 1 commit into
Open
chore(styles): remove ion-icon and share the arrow mask mixin#4703thetaPC wants to merge 1 commit into
thetaPC wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
<ion-icon>renders nothing on the docs site. No package provides it and no script registers it, so it's an empty element wherever it appears. Confirmed in production as well as locally.Three usages in
src/:ioniconprop that 0 of 428<DocsCard>invocations pass.What is the new behavior?
ion-iconis gone fromsrc/entirely, including its type declaration, so it can't come back unnoticed.static/icons/arrow-forward-outline.svg, already in the repo and already used this way by the navbar CTAicon-maskmixin in a newsrc/styles/_mixins.scss, shared by both callers instead of hand-rolled twiceDocsCardbranch, itsioniconprop, and.Card-ioniconCSS are removed, along with DocDemo's commented-out element and orphaned ruleThe three remaining custom elements are typed properly rather than
any:<docs-cards clazz={1}>is now a type error where it used to compile.Does this introduce a breaking change?
One visible change, and it's the point: the App Wizard arrow now appears.
Other information
The 121
<ion-icon>references in markdown are untouched. Every one is inside a code fence, teaching readers to use it in their own apps.ion-iconalso still works inside playground demos, since those iframes load Ionic from a CDN. Only the docs chrome was affected.The mixin takes
$urlas an argument rather than owning it. The two callers need different depths for the same file,../../from the navbar partial and../../../../../from the CSS module, because Sass inlines partials intocustom.scsswhile a module resolves from its own directory. That's documented in the mixin, since it's the part that will catch someone out.Audit of the other two tags, for the record:
device-previewis genuinely registered viadefineCustomElement(), anddocs-card/docs-cardshave no JS definition but are load-bearing CSS hooks for the card grid. Both are fine as-is.