fix: defer response parsing in raise_for_status to error paths only#180
Merged
Merged
Conversation
Parse the response JSON body and decode the reason only when an error is actually raised, avoiding unnecessary work on successful responses. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
daniel-oronsi
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
response.reasononly when an error is actually raised, instead of on every response passed toraise_for_status.response.json()parsing on successful responses.Changes
intezer_sdk/api.py: moved JSON parsing into the4xx/5xxbranch and reason decoding into theshould_raiseblock.🤖 Generated with Claude Code
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Defer parsing the
raise_for_statusresponse body and decodingresponse.reasonuntil error branches run sointezer_sdk.apiskips extra work on successful responses. Update package version metadata and the change log to mark the new 1.27.6 release.__version__and add the 1.27.6 entry inCHANGESto document the deferred parsing adjustment.Modified files (2)
Latest Contributors(2)
response.reasoninraise_for_statusuntil the 4xx/5xx branch triggers so only error responses incur the extra work.Modified files (1)
Latest Contributors(2)