[SYCL] Add compatible targets to -fsycl-targets#22170
Conversation
Add bmg, dg2, mtl and ptl targets.
dm-vodopyanov
left a comment
dm-vodopyanov
left a comment
There was a problem hiding this comment.
LGTM, can we add some E2E tests?
Sure, but I'd say it looks excessive, like in the test we see that clang generates the ocloc call with the right @sarnex btw do we have MTL/PTL runners? |
|
no only ARL i think |
The idea is to check that these binaries generated by compatible targets work fine in run time on at least 2 compatible HW. It is ok to check that in internal CI as well where we have more HW |
|
@intel/dpcpp-clang-driver-reviewers could you take a look please. |
| @@ -0,0 +1,4 @@ | |||
| // REQUIRES: arch-intel_gpu_ptl_u || arch-intel_gpu_ptl_h | |||
There was a problem hiding this comment.
add intel_gpu_nvl_u*, intel_gpu_nvl_h*, intel_gpu_nvl_s, intel_gpu_wcl
| if (CompileTarget == "intel_gpu_mtl") | ||
| return ArchName == "intel_gpu_mtl_h" || ArchName == "intel_gpu_mtl_u"; | ||
| if (CompileTarget == "intel_gpu_ptl") | ||
| return ArchName == "intel_gpu_ptl_h" || ArchName == "intel_gpu_ptl_u"; |
There was a problem hiding this comment.
this should include also the intel_gpu_nvl_u*, intel_gpu_nvl_h*, intel_gpu_nvl_s, intel_gpu_wcl archs
There was a problem hiding this comment.
Addressed this and above comments in a4776c6
5 participants
Add bmg, dg2, mtl and ptl targets.