feat(otlp-exporter): add span factory base structure#504
Open
arjun-rajappa wants to merge 12 commits into
Open
feat(otlp-exporter): add span factory base structure#504arjun-rajappa wants to merge 12 commits into
arjun-rajappa wants to merge 12 commits into
Conversation
pvital
reviewed
May 26, 2026
pvital
left a comment
pvital
left a comment
Member
There was a problem hiding this comment.
It looks good to me, but why are the tests failing?
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
span-convertor-base
branch
from
2a6884c to
41b2efb
Compare
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
…truct Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
span-convertor-base
branch
from
72ed149 to
9ee586a
Compare
pvital
requested changes
Jun 11, 2026
pvital
left a comment
pvital
left a comment
Member
There was a problem hiding this comment.
Please fix the SonarQube-reported issues.
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
span-convertor-base
branch
from
37a4303 to
c6d8a7e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.