dom: normalize null namespace in getNamedItemNS - #253
Open
iliaal wants to merge 1 commit into
Open
Conversation
The named-item refactor moved getNamedItem and getNamedItemNS onto a shared lookup where a null namespace fell back to qualified-name matching, letting getNamedItemNS(null, name) return attributes that do have a namespace. Split the two entry points into dedicated handler methods: the null-namespace lookup now only matches attributes without a namespace (with HTML adjusted-local-name handling), while getNamedItem() and array/property access keep qualified-name matching. Sibling audit found no other affected paths; getAttributeNS(), hasAttributeNS() and getAttributeNodeNS() already use xmlHasNsProp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getNamedItemNS() with a null namespace incorrectly matched attributes that have one after a refactor funneled both named-item lookups through one handler path where null fell back to qualified-name matching. The entry points now split into dedicated vtable methods: the null-namespace lookup matches only attributes without a namespace via xmlHasNsProp() with a null namespace, while getNamedItem(), array access and property access keep qualified-name matching. getAttributeNS(), hasAttributeNS() and getAttributeNodeNS() were audited and are unaffected.