Robustify dls2 shutdown procedure - #339
Open
mich-pest wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making dls2 more robust given the several failure that are occasionally faced by users (e.g.
dls_frameworknot properly killed on shutdown requests). A couple of classes have been added to make the behavior match the expectations after Ctrl+C is pressed.OwnedProcessclassIt belongs to the framework supervision level rather than inside individual layers.
It separates two concerns: layer lifecycle (components handle graceful, semantic shutdown and OS process lifecycle (RunDLS2 owns process groups and ensures all descendants are terminated and reaped).
Detailed procedure:
SIGTERM, thenSIGKILLas a final fallback.ShutdownSignalclassIt converts
SIGINTandSIGTERMinto safe, application-level shutdown requests, robustifying shutdown behavior for both the framework and individual components.Detailed procedure: